Improved exception handling in EventuallyPin.findAllPinned() #843
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #843 +/- ##
============================================
+ Coverage 54.5% 54.61% +0.11%
- Complexity 1705 1709 +4
============================================
Files 123 123
Lines 9785 9785
Branches 1372 1372
============================================
+ Hits 5333 5344 +11
+ Misses 4023 4013 -10
+ Partials 429 428 -1
Continue to review full report at Codecov.
|
Member
|
Nice stuff. |
Jawnnypoo
approved these changes
Jul 16, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code in the callback starting at L172 doesn't check if the task is faulted, and assumes it's successful by iterating over the result's list.
So there is a potential null pointer exception at L175.
Also in other parts of the sdk onSuccessTask is used for the same case :
Parse-SDK-Android/Parse/src/main/java/com/parse/ParsePinningEventuallyQueue.java
Line 583 in e86b920